Fix Organization.overquota exception logging

[thedae]

Rollbar error: https://rollbar.com/carto/CartoDB/items/43042/ . Thanks @rafatower for reporting the exception.

Taking a look at this piece of code:

rescue Carto::Organization::OrganizationWithoutOwner => error
  log_warning(message: 'Skipping inconsistent organization', organization: self, exception: error)
  false
end

The problem is that the Carto::Organization.overquota static method was logging self as organization field in the log entry, but since this method is static, the field was the class itself, not the instance of Carto::Organization. The log looked like this:

{
  "organization": "Carto::Organization",
  "exception": {
    "class": "Carto::OrganizationCommons::OrganizationWithoutOwner",
    "message": "Organization carto-org has no owner",
    "backtrace_hint": [
      "/cartodb/app/models/carto/organization.rb:168:in `require_organization_owner_presence!'",
      "/cartodb/app/models/carto/organization.rb:63:in `get_geocoding_calls'",
      "/cartodb/app/models/carto/organization.rb:43:in `block in overquota'",
      "/var/lib/gems/2.5.0/gems/activerecord-4.2.11.3/lib/active_record/relation/batches.rb:51:in `block (2 levels) in find_each'",
      "/var/lib/gems/2.5.0/gems/activerecord-4.2.11.3/lib/active_record/relation/batches.rb:51:in `each'"
    ]
  },
  "timestamp": "2020-09-28 07:43:19 +0000",
  "levelname": "warning",
  "cdb-user": null,
  "event_message": "Skipping inconsistent organization"
}

I've replaced organization: self with organization: o and removed the message interpolation:

{
  "organization": "carto-org",
  "exception": {
    "class": "Carto::OrganizationCommons::OrganizationWithoutOwner",
    "message": "Organization has no owner",
    "backtrace_hint": [
      "/cartodb/app/models/carto/organization.rb:168:in `require_organization_owner_presence!'",
      "/cartodb/app/models/carto/organization.rb:63:in `get_geocoding_calls'",
      "/cartodb/app/models/carto/organization.rb:43:in `block in overquota'",
      "/var/lib/gems/2.5.0/gems/activerecord-4.2.11.3/lib/active_record/relation/batches.rb:51:in `block (2 levels) in find_each'",
      "/var/lib/gems/2.5.0/gems/activerecord-4.2.11.3/lib/active_record/relation/batches.rb:51:in `each'"
    ]
  },
  "timestamp": "2020-09-28 07:45:07 +0000",
  "levelname": "warning",
  "cdb-user": null,
  "event_message": "Skipping inconsistent organization"
}

[rafatower]

👍