-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ch80914/improve error messages while importing #15893
Merged
jgoizueta
merged 37 commits into
master
from
feature/ch80914/improve-error-messages-while-importing
Nov 3, 2020
Merged
Feature/ch80914/improve error messages while importing #15893
jgoizueta
merged 37 commits into
master
from
feature/ch80914/improve-error-messages-while-importing
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all connector errors, the information returned in the import status used to be: { // ...
"get_error_text": {
"title": "Unknown",
"what_about": "Sorry, something went wrong and we're not sure what. Try\n uploading your file again, or <a href='mailto:support@carto.com?subject=Unknown error'>contact us</a> and we'll try to help you quickly.",
"source": "cartodb"
}
} Now it is more informative: { // ...
get_error_text: {
source: "cartodb"
title: "Connector Error"
what_about: "Executing ODBC query to get schema↵SQL compilation error:↵syntax error line 1 at position 0 unexpected 'OOPSIE'.↵↵"
}
} And it appears like this in the UI: |
Dear Rubocop:
|
Jesus89
approved these changes
Oct 16, 2020
…le-importing # Conflicts: # package.json
…le-importing # Conflicts: # package.json
jgoizueta
deleted the
feature/ch80914/improve-error-messages-while-importing
branch
November 3, 2020 10:55
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.clubhouse.io/cartoteam/story/80914
This improves import error messages for connectors by extracting information from the logs in the case of generic (9999) errors.