Adapt default Rails mails logs to JSON format #15894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiedes
changed the title
amiedes
force-pushed
the
feature/ch94485/research-how-to-update-action-mailer-logging
branch
from
c7b377c
to
295c98b
Compare
…ion-mailer-logging
amiedes
deleted the
feature/ch94485/research-how-to-update-action-mailer-logging
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/cartoteam/story/94485
What does this PR do?
Installs the new version of cartodb-commons which includes improvements to the email logs. Now they'll look as follows:
There are still improvements that can be done but this is the most I could get without altering the default payload of the events emitted by Rails.
Related Rails documentation
https://guides.rubyonrails.org/active_support_instrumentation.html#action-mailer