Migrate SharedEntity, LayerNodeStyle and ExternalSource to ActiveRecord #15920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
chore/ch109279/migrate-organization-model-to-activerecord
to
master
November 10, 2020 08:00
amiedes
force-pushed
the
amiedes/migrate-models-to-activerecord
branch
2 times, most recently
from
9b32222
to
8da8a93
Compare
amiedes
changed the title
amiedes
force-pushed
the
amiedes/migrate-models-to-activerecord
branch
from
8da8a93
to
680a34d
Compare
amiedes
commented
Nov 10, 2020
| @@ -15,7 +15,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| # This script will exit if any of these files is found in the head branch. | |||
| ORM_FILES=$(git grep -l 'class.*Sequel::Model' -- app/models) | |||
| ORM_FILES=$(git grep -l 'class.*< Sequel::Model\|class DBService' -- app/models) | |||
There was a problem hiding this comment.
This prevents some models which include the Sequel::Model string (but don't inherit from it) to be flagged by the ORM check.
Also, considers DBService a "Sequel model", as it relies heavily on ::User
amiedes
force-pushed
the
amiedes/migrate-models-to-activerecord
branch
from
9f87031
to
edf9ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates several small models from
SequeltoActiveRecord.There are several linter warnings about the usage of instance variables within specs, but I'd appreciate if I could leave it like that in order to avoid doing too many spec refactoring.
Acceptance
I've checked in staging: