Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify storage metrics endpoint: mock #15932

Merged
merged 14 commits into from
Nov 25, 2020
Merged

Modify storage metrics endpoint: mock #15932

merged 14 commits into from
Nov 25, 2020

Conversation

juanrmn
Copy link
Member

@juanrmn juanrmn commented Nov 13, 2020

@juanrmn juanrmn marked this pull request as ready for review November 17, 2020 08:34
@juanrmn juanrmn requested a review from thedae November 17, 2020 08:34
thedae
thedae approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@thedae thedae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I left a non-blocking comment

@juanrmn
Copy link
Member Author

juanrmn commented Nov 25, 2020

There is a failing test, but it seems to be related to docker images, nothing to do with the PR changes. So I'm going to merge it.

@juanrmn juanrmn merged commit bea824b into master Nov 25, 2020
@juanrmn juanrmn deleted the feature/ch116623/modify-storage-metrics-endpoint branch November 25, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedae thedae thedae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanrmn @thedae