Add new user metrics to Home page #15950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josmorsot
force-pushed
the
feature/ch121627/add-metrics-i-memory
branch
2 times, most recently
from
f0f625a
to
9c99f7f
Compare
...assets/javascripts/new-dashboard/components/Tooltip/tooltip-component/tooltip-component.scss
Outdated
Show resolved
Hide resolved
...assets/javascripts/new-dashboard/components/Tooltip/tooltip-component/tooltip-component.scss
Outdated
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/components/Tooltip/tooltip.html
Outdated
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/components/Tooltip/tooltip.scss
Outdated
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/MapLoadsQuota.vue
Show resolved
Hide resolved
| :availableQuota="getAmountInUnit(availableQuota)" | ||
| :unit="getUnit(availableQuota)" | ||
| :formatToLocale="false" | ||
| helpText="TODO" |
There was a problem hiding this comment.
I guess this TODO should be replaced properly!
There was a problem hiding this comment.
Yes, @borja-munoz I need text and links for each one
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/MemoryQuota.vue
Outdated
Show resolved
Hide resolved
Josmorsot
force-pushed
the
feature/ch121627/add-metrics-i-memory
branch
from
5d1b76b
to
f0bdad2
Compare
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/StackedQuotaWidget.vue
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/StackedQuotaWidget.vue
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/StackedQuotaWidget.vue
Outdated
Show resolved
Hide resolved
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/StackedQuotaWidget.vue
Show resolved
Hide resolved
VictorVelarde
changed the title
lib/assets/javascripts/new-dashboard/pages/Home/QuotaSection/MemoryQuota.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM. Just small details, most of them already tackled by you.
Don't forget to drop a line into NEWS (the changelog) to pass the checks.
Please also add the acceptance description in a note inside the header of this PR, so we can test at staging cloud. Once that acceptance is ready to be passed, ping me and also @borja-munoz. Thx!
|
@VictorVelarde @borja-munoz I've added info for acceptance test. |
Josmorsot
force-pushed
the
feature/ch121627/add-metrics-i-memory
branch
from
a32f3e1
to
06f7c09
Compare
VictorVelarde
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Last changes at FE LGTM @Josmorsot. Not sure if anything else is required on the backend side before merging. @thedae
Josmorsot
force-pushed
the
feature/ch121627/add-metrics-i-memory
branch
from
870fd08
to
55ef3fb
Compare
added 3 commits
December 11, 2020 17:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Feature/ch121627 (project dashboard metrics)
How to check
Login using juanra-do-org-admin, this user has subscriptions to DO so you'll check that appears Your plan and addons. Subscribing a public data the remaing quota for your plan should change. Subscribing a premium dataset addons size must change (It shouldn't modify remaining quota for your plan)
Login using metrics-empty-user, this user is a new one so you chan check how appears in an empty user. If you import some CSV datasets should be updated. As it user doesn't have subscriptions, both sections should be hidden. If you mark FF
map_loads_metric_disabledMap loads is not visible.