Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubsub to 2.3.0 #16038

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

rafatower
Copy link
Contributor

@rafatower rafatower commented Jan 11, 2021

Update pubsub to ~> 2.3 and some other dependencies. In particular I
had to update gapic manually in order to solve a conflict, by issuing
the following:

bundle update gapic-common

A more aggressive update can be performed with bundle update (no
extra gem) but did not want to run the risk (it can be done in a
latter PR).

Related to CartoDB/cartodb-common#36 that should be merged and released first (after passing the tests), then make this point to the next tagged version.

Update pubsub to ~> 2.3 and some other dependencies. In particular I
had to update gapic manually in order to solve a conflict, by issuing
the following:

    bundle update gapic-common

A more aggressive update can be performed with `bundle update` (no
extra gem) but did not want to run the risk (it can be done in a
latter PR).
Copy link
Contributor

@amiedes amiedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafatower rafatower marked this pull request as ready for review January 12, 2021 10:47
@rafatower rafatower merged commit c4b7266 into master Jan 12, 2021
@rafatower rafatower deleted the chore/ch128685/update-pubsub-ruby-clients-to-2-3-0 branch January 12, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants