Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Organization CRUD actions started by CartoDB #16062

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Migrate Organization CRUD actions started by CartoDB #16062

merged 4 commits into from
Jan 21, 2021

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Jan 20, 2021 •
edited
Loading

Story details: https://app.clubhouse.io/cartoteam/story/128509

Related PR in Central: https://github.com/CartoDB/cartodb-central/pull/3026

What does this PR do?

  • Removes logic associated with Organization creation/deletion launched from Builder. Currently we're always starting these processes from Central, so we've decided to remove this legacy code to make maintenance easier.
  • Adapts the payload for the update_organization event

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #128509: Migrate Organization CRUD actions started by CartoDB.

@amiedes amiedes force-pushed the feature/ch128509/migrate-organization-crud-actions-started branch from 709dc8f to e7a0c98 Compare January 20, 2021 15:01
@amiedes amiedes marked this pull request as ready for review January 20, 2021 15:14
@amiedes
Remove logic to delete organizations from Builder
c859584 
After discussing we've decided not to support this anymore as nobody is using it, it's dangerous and maintaining it requires an extra effort
@amiedes
Remove unused Central#create_organization method
ff2d491
@amiedes
Remove innecesary level of indirection and fix payload attributes
b88b93a
@amiedes amiedes force-pushed the feature/ch128509/migrate-organization-crud-actions-started branch from e7a0c98 to b88b93a Compare January 21, 2021 07:40
rafatower
rafatower approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app/models/concerns/cartodb_central_synchronizable.rb Show resolved Hide resolved
@amiedes amiedes merged commit d4fa42f into master Jan 21, 2021
@amiedes amiedes deleted the feature/ch128509/migrate-organization-crud-actions-started branch January 21, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafatower rafatower rafatower approved these changes

@manmorjim manmorjim Awaiting requested review from manmorjim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amiedes @rafatower