[ch140705] Sanitize column names on overwrite import #16208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources
Context
This corner case appears when a table is imported using the
overwrite
collision strategy, and the columns required sanitization. For example, when the column name starts with a number (1234_column
), an underscore will be added (_1234_column
). First import is successfully, but the second one compares the schemas. Since the sanitization is executed on table creation (almost as last step), the code is going to compare1234_column
with_1234_column
that are indeed different. So anIncompatibleSchemas
exception will be raised.The idea is to apply the sanitization to the column names of the original schemas in order to compare the existing table's schema with the real names that the new table would have.
Changes
overwrite
.overwrite_register