Feature/ch136327/implement oauth connection for bigquery #16218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-with-tileset-list Fix invalid query for listing no tilesets
…y' of github.com:CartoDB/cartodb into feature/ch136326/implement-oauth-connection-for-bigquery
|
This pull request has been linked to Clubhouse Story #136327: Implement OAuth connection for BigQuery. |
Josmorsot
changed the base branch from
master
to
feature/ch136326/implement-oauth-connection-for-bigquery
|
Before merge we need to:
|
complete? validates, so checks for error, so it shouldn't be used in errors!
To make evident the former incomplete? method is not the negation of compliete?
complete? validates, so checks for error, so it shouldn't be used in errors!
To make evident the former incomplete? method is not the negation of compliete?
…y' into feature/ch136327/implement-oauth-connection-for-bigquery
…y' of github.com:CartoDB/cartodb into feature/ch136327/implement-oauth-connection-for-bigquery
jgoizueta
reviewed
Mar 31, 2021
…y' into feature/ch136327/implement-oauth-connection-for-bigquery
…y' of github.com:CartoDB/cartodb into feature/ch136327/implement-oauth-connection-for-bigquery
…y' into feature/ch136327/implement-oauth-connection-for-bigquery # Conflicts: # NEWS.md # package-lock.json
Otherwise they won't appear in the Dashboard and the user won't be able to delete them.
…y' into feature/ch136327/implement-oauth-connection-for-bigquery
…6327/implement-oauth-connection-for-bigquery
…y' into feature/ch136327/implement-oauth-connection-for-bigquery
…y' of github.com:CartoDB/cartodb into feature/ch136327/implement-oauth-connection-for-bigquery
Josmorsot
deleted the
feature/ch136327/implement-oauth-connection-for-bigquery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.