-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dataset version in subscription list and details #16235
Merged
Josmorsot
merged 26 commits into
master
from
feature/ch118173/include-dataset-version-in-catalog-and-my
Mar 31, 2021
Merged
Show dataset version in subscription list and details #16235
Josmorsot
merged 26 commits into
master
from
feature/ch118173/include-dataset-version-in-catalog-and-my
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Clubhouse Story #118173: Include dataset version in Catalog and My Subscriptions page. |
Jesus89
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
After validating this in staging we can merge
…-my' of github.com:CartoDB/cartodb into feature/ch118173/include-dataset-version-in-catalog-and-my
Josmorsot
changed the title
added version and replace dup property by provider name
Show dataset version in subscription list and details
Mar 31, 2021
Josmorsot
deleted the
feature/ch118173/include-dataset-version-in-catalog-and-my
branch
March 31, 2021 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
https://app.clubhouse.io/cartoteam/story/118173/include-dataset-version-in-catalog-and-my-subscriptions-page
https://app.clubhouse.io/cartoteam/story/138264/data-catalog-identify-provider-in-dataset-title