Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch142882] Fix OAuth all datasets scope when there is a temp importing table #16252

Merged

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Apr 12, 2021

Resources

Context

  • When you are trying to use the datasets:r:* wildcard for OAuth application scoping, the process fails if there is a table in the cdb_importer schema (temporal tables used in import processes). The reason is that the tables with permission returned by user.db_service.tables_granted are not the same than the ones returned by user.db_service.all_tables_granted_hashed. Since the second one is ignoring the tables in the cdb_importer schema, and they are temporal tables not related with the OAuth permissions, the idea would be to ignore this schema also in the first method.

Changes

  • Add cdb_importer to the list of ignored schemas in Carto::UserDBService#table_grants.

@shortcut-integration
Copy link

@Shylpx Shylpx changed the title Avoid listing cdb_importer schema in user_db_service [ch142882] Fix OAuth all datasets scope when there is a temp importing table Apr 12, 2021
Copy link
Contributor

@amiedes amiedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants