Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit start parameter for dropbox connector #16264

Merged

Conversation

manmorjim
Copy link
Contributor

Dropbox connector iterates over all the pages using the start parameter. In some point, if the user has a lot of files, the start parameter may be not in the range of the Dropbox API, throwing a 400 error with the message start: 10000 is not within range [0, 9999]

This PR fixes that error by limit the start parameter to 9999.

More context: https://app.clubhouse.io/cartoteam/story/147166/covidanalytics-error-in-call-to-api-function

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #147166: [covidanalytics] Error in call to API function.

@manmorjim manmorjim marked this pull request as ready for review April 20, 2021 07:00
Copy link
Contributor

@thedae thedae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manmorjim manmorjim merged commit 63e3057 into master Apr 20, 2021
@manmorjim manmorjim deleted the feature/ch147166/covidanalytics-error-in-call-to-api-function branch April 20, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants