Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add do_bq_project and do_bq_dataset to api/v3/me endpoint #16276

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

rafatower
Copy link
Contributor

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #149099: Return access information in BigQuery.

@rafatower rafatower force-pushed the feature/ch149099/return-access-info-for-bq branch from 8de32ed to 0a98c64 Compare April 26, 2021 15:45
@rafatower rafatower marked this pull request as ready for review April 26, 2021 15:47
@rafatower rafatower changed the title Return access information in BigQuery Add do_bq_project and do_bq_dataset to api/v3/me endpoint Apr 27, 2021
Comment on lines +247 to +248
do_bq_project: @user&.gcloud_settings&.[](:bq_project),
do_bq_dataset: @user&.gcloud_settings&.[](:bq_dataset),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had never seen the syntax foo[](:key) 😮

Copy link
Contributor

@manmorjim manmorjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rafatower rafatower merged commit 79cbcee into master Apr 27, 2021
@rafatower rafatower deleted the feature/ch149099/return-access-info-for-bq branch April 27, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants