[ch149080] Avoid updating analysis nodes more than once when moving layers in Builder #16279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #149080: [kqednews] Error reordering layers when the Intersect and Aggregate analysis is present. |
Jesus89
approved these changes
May 7, 2021
There was a problem hiding this comment.
Code LGTM
Consider adding a test here: https://github.com/CartoDB/cartodb/blob/master/lib/assets/test/spec/builder/data/user-actions.spec.js#L1718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources
Context
When a layer is moved in Builder, the analysis node of each layer is updated. The problem starts when a layer contains analysis nodes from other layers. For example, when there are "intersect & aggregate analysis" linking two layers, because when a node is updated, the other nodes from layers that contain that node are also updated. So, the same request is performed more than once, and Maps API sends a
429error as a result.To avoid that error, since the action to move layers is updating the analysis node of all layers, a flag is being added to save only the node associated with the current layer, instead of the ones from all the layers that contain the node from the current layer.
Changes
moveLayeraction in order to update each analysis node only once.saveAnalysisForLayer.