Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user migration export/import logs #16298

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Fix user migration export/import logs #16298

merged 3 commits into from
Jun 9, 2021

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Jun 8, 2021

Context

  • Logs for UserMigrationExport and UserMigrationImport are not being saved.

Changes

  • Always call store to save logs.

@Shylpx Shylpx requested a review from amiedes June 8, 2021 11:03
@Shylpx Shylpx self-assigned this Jun 8, 2021
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #154127: MIGRATION OF CAIXABANK FINISHED. STATE: FAILURE.

amiedes
amiedes approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@amiedes amiedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shylpx Shylpx force-pushed the feature/ch154127/migration-of-caixabank-finished-state-failure branch from a422c3e to f00267a Compare June 8, 2021 14:21
@Shylpx Shylpx merged commit 7278ae3 into master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiedes amiedes amiedes approved these changes

Assignees

@Shylpx Shylpx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shylpx @amiedes