Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to hide sharing tab #16299

Merged
merged 5 commits into from
Jun 8, 2021
Merged

Allow to hide sharing tab #16299

merged 5 commits into from
Jun 8, 2021

Conversation

Josmorsot
Copy link
Contributor

No description provided.

@Josmorsot Josmorsot marked this pull request as ready for review June 8, 2021 13:37
ilbambino
ilbambino approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@ilbambino ilbambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VictorVelarde VictorVelarde self-requested a review June 8, 2021 14:39
VictorVelarde
VictorVelarde approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also the piece on viewer (CartoDB/viewer#28)

@VictorVelarde VictorVelarde self-requested a review June 8, 2021 14:44
@Josmorsot Josmorsot merged commit a40a5b7 into master Jun 8, 2021
@Josmorsot Josmorsot deleted the ivan/flag-hide-sharing branch June 8, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilbambino ilbambino ilbambino approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josmorsot @VictorVelarde @ilbambino