Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use DO Catalog as embedded component in CARTO Workspace (carto 3) #16325

Merged
merged 17 commits into from
Aug 11, 2021
Merged

Refactor to use DO Catalog as embedded component in CARTO Workspace (carto 3) #16325

merged 17 commits into from
Aug 11, 2021

Conversation

Josmorsot
Copy link
Contributor

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #171486: DATA CATALOG / Embed DO catalog as new section.

@VictorVelarde VictorVelarde marked this pull request as draft August 3, 2021 15:52
@VictorVelarde VictorVelarde changed the title refactor to use do-catalog as embedded component in CARTO Workspace Refactor to use DO Catalog as embedded component in CARTO Workspace (carto 3) Aug 6, 2021
VictorVelarde
VictorVelarde approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 It looks fine. Just be sure to plan a QA session coordinated with the deployment.

Remember that there are 2 PRs to create:

  • this one, to apply it to CARTODB
  • another PR, after publication, on PUBLIC Website pointing to public assets

VictorVelarde
VictorVelarde suggested changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but CI must be green before merging

Jesus89
Jesus89 reviewed Aug 6, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Josmorsot Josmorsot marked this pull request as ready for review August 6, 2021 11:15
VictorVelarde
VictorVelarde reviewed Aug 9, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
VictorVelarde
VictorVelarde approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@VictorVelarde
Copy link
Contributor

PR looks good, but please link staging url in card, so @AnaDiaz85 can test also catalog there

@Josmorsot Josmorsot force-pushed the feature/ch171486/data-catalog-embed-do-catalog-as-new-section branch from 7fa3886 to 9009e6d Compare August 10, 2021 12:28
@Josmorsot Josmorsot merged commit 8a122d6 into master Aug 11, 2021
@Josmorsot Josmorsot deleted the feature/ch171486/data-catalog-embed-do-catalog-as-new-section branch August 11, 2021 13:50
@Shylpx Shylpx mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus89 Jesus89 Jesus89 left review comments

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Josmorsot @VictorVelarde @Jesus89 @Shylpx