Feature/sc 177364/feature request add cloud information to #16349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b6130ae.
|
This pull request has been linked to Shortcut Story #177364: Feature request: Add cloud information to Builder Dashboard. |
Shylpx
approved these changes
Sep 29, 2021
| @@ -6,7 +6,7 @@ module FrontendConfigHelper | |||
|
|
|||
| def frontend_config_hash(user = current_user) | |||
| config = { | |||
| region: Cartodb.get_config(:bigquery_region), | |||
| region: Cartodb.get_config(:bigquery_region) ? Cartodb.get_config(:bigquery_region).upcase : nil, | |||
There was a problem hiding this comment.
If you want to call a method only if it is defined, you can also use try: https://apidock.com/rails/v4.2.1/Object/try, instead of a conditional ternary operator. That way, Cartodb.get_config(:bigquery_region) will call upcase only if it is defined, and it'll return nil otherwise.
There was a problem hiding this comment.
I've never seen the try option, going to change it! Thanks so much!! 🙇🏼
moicalcob
deleted the
feature/sc-177364/feature-request-add-cloud-information-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources
Shortcut story
Context
The user's database location is needed to perform operations, such as using the SE for BQ. The users can't find this information easily in CARTO.
Changes
The database's location is shown in the user's profile page now.