Display notifications about "New CARTO Platform" release #16352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVelarde
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Code LGTM @Josmorsot. Don't merge until QA is finished and after it we need to coordinate with other people too
|
Image aspect ratio looks a bit distorted if on 'medium' size @Josmorsot: |
| const notificationIsVisible = (date) => { | ||
| if (date) { | ||
| const today = new Date().getTime(); | ||
| const duration = 30 * 24 * 60 * 60 * 1000; |
There was a problem hiding this comment.
Everytime I see these computations I will appreciate a more clear name, to avoid reading computation itself. So in this case I would just suggest a variable name like 'oneMonth', which has a clearer intention
VictorVelarde
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show notifications about new CARTO release