Notify about the limit of 4096 named maps in Builder #16368
Conversation
|
This pull request has been linked to Shortcut Story #178449: Notify about the limit of 4096 named maps in Builder. |
lib/carto/named_maps/api.rb
Outdated
| tables = Carto::UserTable.where(user_id: user.id, privacy: 0).limit(100).order('updated_at') | ||
| named_maps_ids = tables.map { |t| "tpl_#{t.visualization.id.tr('-', '_')}" } | ||
|
|
||
| named_maps_ids.each do |id| |
There was a problem hiding this comment.
Do you know if this method is executed synchronously in some point? I mean, if this is executed for example when a map is published, and the UI is waiting for a response, this will delay a lot the response.
If that is the case, my recommendations would be to create a new Resque worker class, and just enqueue it here. So it can be processed in the background.
Let me know if you have any question :)
There was a problem hiding this comment.
Okay! I'll try to do it, as it's executed synchronously 🤔 But I can't promise you that I'll be able to do it without any help 😅
|
Very nice job 🚀!! Just a few comments and doubts :) |
…f-4096-named-maps
…f-4096-named-maps
…f-4096-named-maps
…f-4096-named-maps
…maps' of github.com:CartoDB/cartodb into feature/sc-178449/notify-about-the-limit-of-4096-named-maps
…f-4096-named-maps
moicalcob
force-pushed
the
feature/sc-178449/notify-about-the-limit-of-4096-named-maps
branch
from
1cfdbf0
to
f14947e
Compare
…f-4096-named-maps
moicalcob
deleted the
feature/sc-178449/notify-about-the-limit-of-4096-named-maps
branch
Resources
Context
cartodb, so we've added a check to delete old named maps if the user is reaching the limit, and Support will get notified about that.Changes
cartodbthat the user is reaching the limit.support-internalthat there is a user reaching the limit.