Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc207379] Update analysis schemas after giving required permissions on user promotion #16390

Merged
merged 4 commits into from
Feb 15, 2022
Merged

[sc207379] Update analysis schemas after giving required permissions on user promotion #16390

merged 4 commits into from
Feb 15, 2022

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Feb 9, 2022

Resources

Context

  • The process to update analysis schema when a user is promoted to organization owner was failing because the user didn't have the required permissions on the new schema. The permissions are required because before changing the query, it is tested with EXPLAIN here.

Changes

  • Update analyses schema after giving required permissions to the user.

@Shylpx Shylpx requested a review from moicalcob February 9, 2022 11:25
@Shylpx Shylpx self-assigned this Feb 9, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #207379: [sounddiplomacy] Account upgrade made no Maps render for account.

@Shylpx Shylpx changed the title [sc207379] Update analyses schema after giving properly permissions [sc207379] Update analysis schemas after giving required permissions on user promotion Feb 9, 2022
moicalcob
moicalcob approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@moicalcob moicalcob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Shylpx Shylpx merged commit 8bd0b09 into master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moicalcob moicalcob moicalcob approved these changes

Assignees

@Shylpx Shylpx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shylpx @moicalcob