Only send JS errors+stats in production [no merge]

[viddo]

Fixes #1892

In addition to the minor code change:

TrackJS:

• Removed trackAjaxFail: false since trackJs lib yields a warning that property is not supported anyway
• Load trackJs on all environments (that has a token set in app_config.yml), but only send errors to trackJs if the config has enabled set to true, i.e.:

trackjs: 
  enabled: true

For Mixpanel:

• Always load mixpanel on all environments (that has a token set in app_config.yml)
• Per Mixpanel's own proposal use a "dev/staging" token for non-production environments to not pollute statistics.

---

Will talk to devops about how to config changes for staging+production environments.

So, effectively we would catch errors at latest in staging, and for devs touching frontend should have the tokens in their dev env app_config.yml to catch errors even earlier.

edit: removed Rails.env usage to load TrackJS

[viddo]

@CartoDB/frontend sounds reasonable?

[xavijam]

Sounds good dude 👍 💃

[viddo]

@zenitraM @lbosque @santisaez do you have any objections or is there anything I might have overlooked? If everything is OK I would need help from you with the following two tasks:

1. set the production TrackJs token for staging's app_config.yml
2. create a "dev token" for Mixpanel and set it for staging's app_config.yml (and pass the token to frontend@ mailing list so "frontend devs" have it too.

[javisantana]

for me it should send stats when we have config for that, doing things in function of rails env gave a lot of problems in the past

[javisantana]

please update news if needed and merge

[viddo]

Re: rails env that's totally reasonable 👍, I'll make sure to fix it.

The reason why it have not been merged yet is because I need help from someone who has admin privileges to staging/production environments and mixpanel to do the necessary changes required by this PR (asked several occasions). I'll get back to this one as soon as I finished the other issues with higher priority related to the new dashboard.

Re: update NEWS, will do once this is ready to be merged.

[viddo]

Based on feedback have done some additional changes. To be able to merge & release this branch I would need the following changes to config/app_config.yml:

For staging:

mixpanel:
   api_key: 'dev-api-key'
   api_secret: 'dev-api-secret'
   token: 'dev-token'
trackjs:
  customer: 'key-used-in-production'
  enabled: false

For production:

trackjs:
  enabled: true

Again, the "dev-*_" strings should be created through Mixpanel's dashboard. @matallo It have come to my attention that you might be able to help me with this? ;)

For the config changes, can someone of Devops @santisaez @zenitraM @azamorano help me out tomorrow Fri to finish this off finally?

[viddo]

retest this please

[Cartofante]

Frontend tests were OK 👍 (details)