Remove tmp & unused files #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 19, 2015 10:42
|
@CartoDB/frontend please code review, I've verified working fine locally, let me know if something was removed/changed wrongly |
|
👍 It looks fine to me, but I would push it to staging to test it there too. |
|
will do! |
|
deployed on |
|
Frontend tests were OK 👍 (details) |
|
Tested on ded01 today again and no weird behaviour. |
|
Frontend tests were OK 👍 (details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2249
Removed cache files
public/tmpfrom repoAlso while at it I saw more things that could be cleaned up:
app/assets/stylesheets/→tmp/sassapp/assets/javascripts/→lib/assets/javascripts/cartodb/sessions/(already defined as a normal JS bundle), to have all JS source code in the same placeapp/assets/javascripts/), that was bundled by sprockets (now done through grunt)scripts/run_js_tests), and its related files