Cached responses [do not merge] #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good to me The only things I can think of is that @xavijam added a wrapper for localStorage for the new dashboard (due to some browser issues I think?), perhaps we need to use the same here? |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to improve the dashboard speed I added this cached sync. What it does is to store the data in local storage using it the next time you fetch it. It always fetch it but you get results faster.
I also prepared it to invalidate the cache when needed based on the namespace you give when create the sync method. It's the same system that subrogate keys use
In this case I'm using it i the visualization list in order to improve the dashboard and the table list speed
cc @CartoDB/frontend
This PR is to discuss this and find problems, before reviewing it, please read https://github.com/teambox/backbone.memoized_sync/blob/master/backbone.memoized_sync.js