Fixes for new dashboard texts #2499

viddo · 2015-02-25T15:22:18Z

Fixes Crop description to max 2 lines in the map cards #2391 by truncating text more:

description with a larger characters:
description with a smaller characters:

Fixes Copy-edit - remove the “to”: “We recommend you export your dataset before deleting.” #2433 show export encouragement -text for delete datasets dialog:

Fixes Misspelling - “There are not datasets. No datasets no fun” → Proposed text: “You haven’t liked any datesets yet #2427 replaced “There are not datasets. No datasets no fun” with proposed text

Fixes #2391

Fixes #2433

Fixes #2427

The previous value was not enough for description with large characters

viddo · 2015-02-25T15:27:17Z

@saleiva @xavijam please review.

xavijam · 2015-02-25T15:29:24Z

Only texts? In that case, not much to say, 👍.

xavijam · 2015-02-25T15:30:25Z

lib/assets/javascripts/cartodb/new_dashboard/maps/maps_item.js

@@ -7,7 +7,7 @@ var LikesView = require('../../new_common/views/likes/view');
 var Utils = require('cdb.Utils');
 cdb.admin = require('cdb.admin');

-var SHORT_DES = 85;
+var SHORT_DES = 45;


No css solution?

saleiva · 2015-02-25T15:33:07Z

👍

xavijam · 2015-02-25T15:34:28Z

IMHO 45 characters for map description is too short.

viddo · 2015-02-25T15:41:01Z

Yes, it's short, and as I wrote on the related issue it's sub-optimal but there is no perfect solution. The CSS approach works perfect on webkit, but for the rest there would be no ellipsis (or other indicator of more text). If you're fine with the following scenario I'm happy to change it to a CSS solution:

webkit:
non-webkit:

xavijam · 2015-02-25T15:43:31Z

How about to adding a white gradient at the end?
For the rest of the browsers, i mean. cc @piensaenpixel

piensaenpixel · 2015-02-25T15:43:57Z

+1 @xavijam love your comment

viddo · 2015-02-25T15:58:51Z

Ah yes, you're right that should do. For the sake of simplicity I would leave the gradient since it's so subtle anyway. Looks OK?

Use gradient to indicate more text on non-webkit browsers, since other non-webkit browsers don’t support multiline text-overflow ellipsis.

viddo · 2015-02-25T16:24:30Z

retest this please

piensaenpixel · 2015-02-25T16:24:57Z

@viddo one question, what do you think about remove the gradient for non-webkit browsers? really if we can show the ellipsis, i think we dont need the gradient

viddo · 2015-02-25T16:26:30Z

But the ellipsis is only available for webkit, so I suggest to leave the gradient.

piensaenpixel · 2015-02-25T16:27:42Z

Sorry... it was my fault. I mean remove the gradient for webkit browsers ;)

piensaenpixel · 2015-02-25T16:33:59Z

and one more thing did you test this when you selected the map? you should change the color of the gradient. :)

Since only applied for MapCard anyway, and need to know the colors to be able to match hover/selected states. Changed transparency to rgba values too to work on firefox

viddo · 2015-02-25T17:10:59Z

@piensaenpixel: Fixed the hover/selected states (good catch!) in the last commit ffb1855.
However I do not see any issue way to opt-out of the gradient for webkit only. That's why I suggested to leave it, to not complicate things by special rules and hacks.

Container must have a width for the text-overflow to work

Render on one row

viddo · 2015-02-25T17:50:17Z

@xavijam fixed privacy indicator in FF as well as the map card titles that was not ellipsed properly there either, see last two commits.

xavijam · 2015-02-25T17:54:16Z

🇺🇸

Cartofante · 2015-02-26T08:06:51Z

Frontend tests were OK 👍 (details)

piensaenpixel · 2015-02-26T08:41:01Z

🇺🇸

Fixes for new dashboard texts

Nicklas Gummesson added 6 commits February 25, 2015 15:32

Truncate description earlier

19bee26

Fixes #2391

Display export-message if is datasets

0b3c4f5

Fixes #2433

Fix typo for no results

ee78fab

Fixes #2427

Show other message for empty liked datasets

565e72c

Truncate desc even more

38ce31a

The previous value was not enough for description with large characters

Use same truncate value as on private dashboard

478fb27

xavijam reviewed Feb 25, 2015
View reviewed changes

Truncate desc by CSS instead

e28c556

Use gradient to indicate more text on non-webkit browsers, since other non-webkit browsers don’t support multiline text-overflow ellipsis.

Move truncation to .MapCard CSS

ffb1855

Since only applied for MapCard anyway, and need to know the colors to be able to match hover/selected states. Changed transparency to rgba values too to work on firefox

Nicklas Gummesson added 2 commits February 25, 2015 18:42

Fix overflowing text for mapcard title in FF

eba0eee

Container must have a width for the text-overflow to work

Fix privacy indicator render in FF

f3c47b1

Render on one row

Nicklas Gummesson added 2 commits February 26, 2015 09:00

Merge branch 'master' into fix-new-dashboard-copy

451a4a9

Update NEWS and version

616ae89

viddo added a commit that referenced this pull request Feb 26, 2015

Merge pull request #2499 from CartoDB/fix-new-dashboard-copy

e7da36f

Fixes for new dashboard texts

viddo merged commit e7da36f into master Feb 26, 2015

viddo deleted the fix-new-dashboard-copy branch February 26, 2015 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for new dashboard texts #2499

Fixes for new dashboard texts #2499

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

xavijam Feb 25, 2015

saleiva commented Feb 25, 2015

xavijam commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

Cartofante commented Feb 26, 2015

piensaenpixel commented Feb 26, 2015

Fixes for new dashboard texts #2499

Fixes for new dashboard texts #2499

Conversation

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

xavijam Feb 25, 2015

Choose a reason for hiding this comment

saleiva commented Feb 25, 2015

xavijam commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

piensaenpixel commented Feb 25, 2015

viddo commented Feb 25, 2015

viddo commented Feb 25, 2015

xavijam commented Feb 25, 2015

Cartofante commented Feb 26, 2015

piensaenpixel commented Feb 26, 2015