Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lighter font weights on new dashboard #2513

Merged
merged 16 commits into from
Mar 2, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Feb 26, 2015

Fixes #2335

Edit: Changed approach after review:

  • Remove lighter font-weight on font-sizes <= 13px
  • Apply special text-rendering overrides for smaller fonts to not have such a bold look.

New screenshots:
screen shot 2015-02-27 at 12 59 54
screen shot 2015-02-27 at 13 08 46
screen shot 2015-02-27 at 15 03 33
screen shot 2015-02-27 at 15 04 41
screen shot 2015-02-27 at 15 18 36
screen shot 2015-02-27 at 15 31 01
screen shot 2015-02-27 at 15 36 01

Due to issues in windows machines that don’t render them fine
@viddo
Copy link
Contributor Author

viddo commented Feb 26, 2015

@carlostallon @xavijam @saleiva as instructed in the issue I've removed the lighter fonts. I'd suggest we do a deploy on staging (none available yet) to really check if this solves it. Thoughts?

@xavijam
Copy link
Contributor

xavijam commented Feb 26, 2015

It is a pity we have to "remove" it, but if some browsers don't render properly, this is the best solution.

@viddo
Copy link
Contributor Author

viddo commented Feb 27, 2015

bump, any feedback on this please?

@saleiva
Copy link
Contributor

saleiva commented Feb 27, 2015

Not the same, but... let's go with it :)

@piensaenpixel
Copy link
Contributor

If we remove the lighter fonts, may be we could try use this property of css
text-rendering: optimizeLegibility;

@viddo
Copy link
Contributor Author

viddo commented Feb 27, 2015

@saleiva @piensaenpixel @xavijam changes based on feedback, see PR desc for screenshots. also deployed on staging (ded02) if you want to have a look yourself. cc @Kartones

@viddo
Copy link
Contributor Author

viddo commented Feb 27, 2015

Screenshot from kartones with the new changes:
image

OK?

@xavijam
Copy link
Contributor

xavijam commented Mar 2, 2015

🇯🇵

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Mar 2, 2015
Remove lighter font weights on new dashboard
@viddo viddo merged commit 5ccc1f1 into master Mar 2, 2015
@viddo viddo deleted the 2335-remove-lighter-font-weights branch March 2, 2015 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Almost unreadable texts
5 participants