Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved pagination for new dashboard #2529

Merged
merged 3 commits into from
Feb 27, 2015
Merged

Improved pagination for new dashboard #2529

merged 3 commits into from
Feb 27, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Feb 26, 2015

Fixes #2413

  • Added the "edge" (only 1 as it was defined in the issue) if there are more pages than can be visible, just like how Github's own pagination works.
  • Also update the pagination model immediately on click, to avoid the re-render delay until a response returns.

screen shot 2015-02-26 at 16 29 13
screen shot 2015-02-26 at 16 29 25
screen shot 2015-02-26 at 16 29 34
screen shot 2015-02-26 at 16 29 59
screen shot 2015-02-26 at 16 30 10

@viddo
Copy link
Contributor Author

viddo commented Feb 26, 2015

ping @xavijam code review
@saleiva you never answered my question in the issue, you want the "previous" and "next" links on the edges as well? :)

@xavijam
Copy link
Contributor

xavijam commented Feb 26, 2015

First and last items don't have round corners and they "hide" grey border
screen shot 2015-02-26 at 17 07 26
.

@viddo
Copy link
Contributor Author

viddo commented Feb 26, 2015

Ouch, good catch. I'll look into that one

@viddo
Copy link
Contributor Author

viddo commented Feb 26, 2015

Fixed 4bbf2c8 --> screen shot 2015-02-26 at 17 13 46

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@viddo
Copy link
Contributor Author

viddo commented Feb 27, 2015

Apart from that detail, any more feedback or OK to go?

@xavijam
Copy link
Contributor

xavijam commented Feb 27, 2015

Reviewing :)

@xavijam
Copy link
Contributor

xavijam commented Feb 27, 2015

🇬🇧

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Feb 27, 2015
Improved pagination for new dashboard
@viddo viddo merged commit 7404d39 into master Feb 27, 2015
@viddo viddo deleted the 2413-improve-pagination branch February 27, 2015 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix current pagination in new dashboard
3 participants