Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round down the quota usage #2561

Merged
merged 3 commits into from
Mar 2, 2015
Merged

Round down the quota usage #2561

merged 3 commits into from
Mar 2, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Mar 2, 2015

Fixes #2547

I'll propose we render the used amount of data with up to 2 decimals if necessary, rounded down to avoid the rounding to be rendered as "10MB" for this kind of edge-case:

screen shot 2015-03-02 at 12 43 23
screen shot 2015-03-02 at 12 44 13

In case the used data has no decimals it renders as before:
screen shot 2015-03-02 at 12 45 00

@viddo
Copy link
Contributor Author

viddo commented Mar 2, 2015

Please review @xavijam

@xavijam
Copy link
Contributor

xavijam commented Mar 2, 2015

Good to me 👍

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Mar 2, 2015
@viddo viddo merged commit 2db3c90 into master Mar 2, 2015
@viddo viddo deleted the 2547-fix-quota-progress-bar branch March 2, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings dropdown progress bar is not correct
3 participants