Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hubspot for stats #2575

Merged
merged 10 commits into from
Mar 4, 2015
Merged

Add Hubspot for stats #2575

merged 10 commits into from
Mar 4, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Mar 3, 2015

Fixes #2471 (and piggyback for #2572 since so small)

Only load and track Hubspot stats if set in app config.

@viddo
Copy link
Contributor Author

viddo commented Mar 3, 2015

@xavijam small change, but please review just in case

@@ -38,7 +38,7 @@ def index
layout = new_dashboard ? 'new_application' : 'application'

respond_to do |format|
format.html { render view, layout: 'application' }
format.html { render view, layout: layout }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@xavijam
Copy link
Contributor

xavijam commented Mar 3, 2015

Update NEWS and ready to go 👍

@viddo
Copy link
Contributor Author

viddo commented Mar 3, 2015

Pending config changes for staging/production to be able to merge, so not ready quite yet.

@viddo
Copy link
Contributor Author

viddo commented Mar 4, 2015

Config updates done and verified working on staging, will release as soon as CI pass.

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Mar 4, 2015
@viddo viddo merged commit e04578b into master Mar 4, 2015
@viddo viddo deleted the 2471-add-hubspot branch March 4, 2015 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send hubspot event when user visits new dashboard
3 participants