Increase top/bottom padding #2721
Conversation
Call correct parent render method
|
@xavijam review the CSS please, AFAIK we don't have any modals that should need scrolling on x-axis, right? |
|
cc @saleiva for reported issue |
|
Have you checked it in the create modal window? |
|
Nope, AFAIK, there isn't any modal with x scroll, so 👍 |
| @@ -23,7 +23,7 @@ body.is-inDialog { | |||
| background: -ms-linear-gradient(top, rgba(white,1) 0%, rgba(white,0.95) 50%, rgba(white,0.9) 100%); | |||
| background: linear-gradient(to bottom, rgba(white,1) 0%, rgba(white,0.95) 50%, rgba(white,0.9) 100%); | |||
| filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#ffffff', endColorstr='#ffffff', GradientType=1 ); | |||
| overflow: scroll; | |||
| overflow-y: scroll; | |||
There was a problem hiding this comment.
BTW, why we set scroll instead of auto?
There was a problem hiding this comment.
Yes, you're right, just noticed it too.. I remove it.
There was a problem hiding this comment.
Don't know if there is any good reason for it, and it's at least not documented here. :/
There was a problem hiding this comment.
I'd set as auto, x and y, wouldn't you?
There was a problem hiding this comment.
Looking in the VCS history I found this: 3e33603
But from what I can see now it should not be necessary anyway.
There was a problem hiding this comment.
Auto is the default so think removing is fine. :)
On Wed, Mar 11, 2015 at 2:36 PM, Javier Álvarez Medina <
notifications@github.com> wrote:
In app/assets/stylesheets/new_common/dialog.css.scss
#2721 (comment):@@ -23,7 +23,7 @@ body.is-inDialog {
background: -ms-linear-gradient(top, rgba(white,1) 0%, rgba(white,0.95) 50%, rgba(white,0.9) 100%);
background: linear-gradient(to bottom, rgba(white,1) 0%, rgba(white,0.95) 50%, rgba(white,0.9) 100%);
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#ffffff', endColorstr='#ffffff', GradientType=1 );
- overflow: scroll;
- overflow-y: scroll;
I'd set as auto, x and y, wouldn't you?
—
Reply to this email directly or view it on GitHub
https://github.com/CartoDB/cartodb/pull/2721/files#r26211653.
|
👍 |
|
Frontend tests were OK 👍 (details) |
…-maps-styles Increase top/bottom padding
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
Fixes #2654
compare with previous: