-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1989 guessing of namedplaces #2809
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bb868d5
First version of guessing of namedplaces #1989
e8c7e86
Fix for the query generator #1989
72cb358
Merge remote-tracking branch 'origin/master' into 1989-guessing-of-na…
1ddb456
Revamp of namedplaces guessing #1989
7c189f9
Fix call to postgres function #1989
2677efa
Fix params when geocoding from guess #1989
741a6dd
Fix small bug in geocode param #1989
63423ff
Merge remote-tracking branch 'origin/master' into 1989-guessing-of-na…
532b14e
Move NamedplacesGuesser to a separate file #1989
5680442
Some tests for NamedplacesGuesser #1989
1640731
remove unused var #1989
fafc058
More tests for NamedplacesGuesser #1989
7931876
Uncomment log line #1989
f985d52
Fix silly typo with singulars/plurals #1989
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replying @javisantana this is the critical part. this is gonna be called through sql api once per column with an array of up to sample size.
Due to the nature of the sampling and the dataset itself, I do not expect having a good hit rate in cache for these queries, nor for the geocodings on the full datasets.
If you're ok with it, then me too and more than happy of releasing it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so why don't we add a metric there? also, if you feel like the call is going to be really expensive we have the option of having a different
geocode_namedplace
that gets not only a single array but an array per column. Are we doing this only for text columns, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to add a metric and check whether performance is a problem or not
Yes, we're just querying text columns.
About sending one single query with all text columns of the sample: do you think it will be more efficient for the general case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be more efficient because you only need to open a connection (at least this).
Let's add that metric and see how it looks