Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "all" infowindow field switch #3021

Merged
merged 2 commits into from
Apr 6, 2015

Conversation

alonsogarciapablo
Copy link
Contributor

Fixes #3008. The internal sortedFields attribute was not being properly set when no fields were selected. I have added a test that reproduces the bug :)

@xavijam can you please take a look? thx!

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@xavijam
Copy link
Contributor

xavijam commented Apr 6, 2015

🇺🇸

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@alonsogarciapablo alonsogarciapablo changed the title Fixes bug in the "Select All" switch Fixes "all" infowindow field switch Apr 6, 2015
alonsogarciapablo added a commit that referenced this pull request Apr 6, 2015
@alonsogarciapablo alonsogarciapablo merged commit 88f6fbc into master Apr 6, 2015
@xavijam
Copy link
Contributor

xavijam commented Apr 6, 2015

💃

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@alonsogarciapablo alonsogarciapablo deleted the 3008-fix-select-all-switch branch April 6, 2015 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"all" infowindow field switch no longer working in production
3 participants