Do not store session for api_key auth #3207 #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! 👍 |
|
Frontend tests were OK 👍 (details) |
|
Great 👍 |
|
There's an issue with |
The current_viewer is taken from the subdomain if the user was previously authenticated. This covers api_key authentication (no session). Also we make sure to return nil if there's no authenticated user in the context of the request. This is very important from a security standpoint.
|
Frontend tests were OK 👍 (details) |
|
@Kartones can you please review the |
|
👍 |
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
Apr 16, 2015
Do not store session for api_key auth #3207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juanignaciosl @Kartones @javisantana mini-review please