Fix subdomainless issues #3334 #3393
Conversation
|
Frontend tests were OK 👍 (details) |
|
cc @santisaez |
rafatower
changed the title
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
rafatower
changed the title
|
Frontend tests were OK 👍 (details) |
|
@javisantana , @Kartones I think this is ready. Please review. I tested it locally setting an IP address as the I also deployed it to a staging and checked I did not break the "subdomainful cloud config" to my best knowledge. Once it passes your review I'll tell Santi to run the on-premise regression. |
| # username.cartodb.com should redirect to the public user dashboard in the maps view if the user is not logged in | ||
| else | ||
| redirect_to CartoDB.url(self, 'public_maps_home') | ||
| # No current_user and no current_viewer so we resort to login page | ||
| redirect_to login_url |
There was a problem hiding this comment.
Why don't using here CartoDB.url(self, 'login') ?
using *_url and *_path is disencouraged as we cannot control Rails generation of the url, so for domain-based urls would create a /u/xxx/user/xxxx ugly (but working) url if I recall correctly, while our CartoDB.url shouldn't
There was a problem hiding this comment.
Just because there's no user in that context, so it was generating stuff like mydomain.lan/user//maps
CartoDB.url(self, 'login') doesn't work either, it generates stuff like http://172.17.0.1:3000/user//login
This is clearly an exception to the rule. If you have a better suggestion...
|
Apart from that... looks nice, thanks for fixing the issues! 👍 |
|
Frontend tests were OK 👍 (details) |
|
@santisaez I think you can generate a build or whatever to test that in an on-premise. I can assist you with it. |
rafatower
changed the title
Fix subdomainless issues #3334
@Kartones please CR
@javisantana this fixes the cases 1 and 2 that you mention in the ticket. There are still some cases I know do not work (logout redirect for instance)