-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gmaps revival #3429
Gmaps revival #3429
Conversation
…mapst push origin gmaps todb into gmaps_revival
now the provider is selected based on the default base layer for the user instead of using configuration
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
retest this please |
@@ -50,6 +50,7 @@ def index | |||
@tables_count = current_user.tables.count | |||
@first_time = !current_user.dashboard_viewed? | |||
@just_logged_in = !!flash['logged'] | |||
@google_maps_api_key = current_user.google_maps_api_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if the user belongs to an organization?
retest this please |
1 similar comment
retest this please |
Frontend tests were OK 👍 (details) |
@javisantana It seems everything is working fine. |
Let's get back GMaps!
this is what changed:
@Kartones I think there are some things to change in the new map.rb
To make it work:
In order to have google maps you need to:
google_maps
.Fixes #3289.