Fixes "No georeferenced data" dialog. #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend tests were OK 👍 (details) |
|
🇪🇸 |
alonsogarciapablo
added a commit
that referenced
this pull request
May 4, 2015
Fixes "No georeferenced data" dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3198.
We were generating the localStorage key using the id (name) of the table. So if you created/imported a new table with the name of a previously existing table, the localStorage key already existed and we din't display that dialog. It's an edge case.
Instead of relying on
table.id, I added themap_idto the key, which is the only attribute that seemed unique in the table metadata (I was planning to usecreated_atbut it wasn't present). I'm open to suggestion on better ways to generate a unique id for the table metadata.@javisantana, this one is for you! :)