Adjust tablename limit to 63 chars (as per docs) fixes #3747 #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend tests were OK 👍 (details) |
|
retest this, please |
|
Frontend tests were OK 👍 (details) |
|
@juanignaciosl or @Kartones please review (whoever is faster 😄) I already tested it in staging so I can tell you it is ok and removes and annoying corner case. |
|
👍 |
1 similar comment
|
👍 |
rafatower
pushed a commit
that referenced
this pull request
May 26, 2015
Adjust tablename limit to 63 chars (as per docs) fixes #3747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@javisantana I think this should be fine. The
alter tablethrough the sql api should fail in other cases. I'm testing it locally and waiting for this to pass the tests.