Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve email template #4190

Merged
merged 21 commits into from
Jul 2, 2015
Merged

improve email template #4190

merged 21 commits into from
Jul 2, 2015

Conversation

matallo
Copy link
Contributor

@matallo matallo commented Jun 24, 2015

close https://github.com/CartoDB/cartodb-central/issues/487

screen shot 2015-06-24 at 18 03 59
screen shot 2015-06-24 at 18 05 34
screen shot 2015-06-24 at 17 55 28
screen shot 2015-06-24 at 17 56 14
screen shot 2015-06-24 at 17 57 25
screen shot 2015-06-24 at 17 58 14

CR @juanignaciosl, btw I couldn't manage the new_organization_user to work, as you have been involved recently in this, can you help me a bit?

please review @CartoDB/design, tested in desktop android gmail and iphone mail

@carlostallon
Copy link

Looking good to me

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@saleiva
Copy link
Contributor

saleiva commented Jun 25, 2015

Ooooh, but we lost the color coding :(
I'd add a bit more of padding since lines are too width for me. Also the error module is a bit weird, either we make it 100% width or we give more margin to it.

@matallo
Copy link
Contributor Author

matallo commented Jun 25, 2015

sure, summoning layout and spacing guys here @carlostallon @josecruz

@carlostallon
Copy link

  • Works better with fixed width.
  • a little bit more of padding could work better
  • I will make the buttons with rounded corners if possible
  • As it's to much text i will align to left, also the button

2015-06-25 16:11 GMT+02:00 Carlos Matallín notifications@github.com:

sure, summoning layout and spacing guys here @carlostallon
https://github.com/carlostallon @josecruz https://github.com/josecruz


Reply to this email directly or view it on GitHub
#4190 (comment).

Carlos Tallón
Designer & Baker

@matallo
Copy link
Contributor Author

matallo commented Jun 25, 2015

  • can't make rounded corners because in mobile it breaks, prefer to leave it like this (already discussed with @piensaenpixel)
  • what do you mean by fixed with?
  • ok to left align
  • "a little bit more of padding" I was expecting more a sketch mockup I could replicate

also, take into account the mobile layout

screen shot 2015-06-25 at 17 30 50

if you need me to send some test just ping me

@matallo
Copy link
Contributor Author

matallo commented Jun 29, 2015

ping @carlostallon

@saleiva
Copy link
Contributor

saleiva commented Jun 29, 2015

I'd assign this to @piensaenpixel

@piensaenpixel
Copy link
Contributor

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@matallo
Copy link
Contributor Author

matallo commented Jul 1, 2015

screen shot 2015-07-01 at 10 49 35
screen shot 2015-07-01 at 10 57 13
screen shot 2015-07-01 at 10 57 59
screen shot 2015-07-01 at 10 59 58
screen shot 2015-06-30 at 20 54 13
screen shot 2015-07-01 at 11 05 22
screen shot 2015-07-01 at 12 37 07
screen shot 2015-07-01 at 12 39 34
screen shot 2015-07-01 at 12 41 55

/cc @piensaenpixel @juanignaciosl (maybe you want to try activate link version)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@saleiva saleiva assigned piensaenpixel and unassigned carlostallon Jul 1, 2015
@matallo
Copy link
Contributor Author

matallo commented Jul 2, 2015

bump

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

matallo added a commit that referenced this pull request Jul 2, 2015
@matallo matallo merged commit bee244a into master Jul 2, 2015
@matallo matallo deleted the 487-mail_import_error branch July 2, 2015 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants