3775 fix geocode shared table rw #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend tests were OK 👍 (details) |
Tested guessing on import and OK, so removing TODO comment.
rafatower
changed the title
|
Frontend tests were OK 👍 (details) |
| @@ -122,6 +122,9 @@ def run! | |||
| rows_geocoded_before = table_service.owner.in_database.select.from(table_service.sequel_qualified_table_name).where(cartodb_georef_status: true).count rescue 0 | |||
|
|
|||
| self.run_geocoding!(processable_rows, rows_geocoded_before) | |||
| rescue => e | |||
| CartoDB.notify_exception(e) | |||
There was a problem hiding this comment.
Could you add context information (table, user...)?
There was a problem hiding this comment.
I'll move all that code, when I put a proper logger #4417
|
👍 |
rafatower
pushed a commit
that referenced
this pull request
Jul 17, 2015
3775 fix geocode shared table rw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3775 Can't geocode table shared with me (with write permissions). At first I tried to fix it by granting sufficient permissions to the user, but turns out it is a limitiation of postgres.
Sbd from @CartoDB/backend please review