Better number normalization fixes #2419 #4530
Merged
+67
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,49 +1,50 @@ | |||
| # encoding: utf-8 | |||
| require 'rspec/core' | |||
There was a problem hiding this comment.
I basically reused the spec file: the only test was not in the Makefile and was not recoverable so I wrote a useful one and got rid of the rest.
|
Frontend tests were OK 👍 (details) |
rafatower
force-pushed
the
2419-improve-casting-to-number
branch
from
938c331
to
67198a6
Compare
|
Frontend tests were OK 👍 (details) |
|
👍 |
|
bump! |
|
@saleiva Rafa is on vacation until tomorrow, he said in his worklog he'd release this tomorrow 😉 |
rafatower
pushed a commit
that referenced
this pull request
Jul 22, 2015
Better number normalization fixes #2419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kartones please review