-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pecan module instead of prior code from cartodb.js #4999
Conversation
Not needed, append to response object since that’s where it’s wanted
Only need to provide the minimum necessary and don’t for the Pecan library to adhere to how CartoDB code is structured/named stuff
Bump! (and re-deployed on ded03 due to update w/ master) |
👍 LGTM |
@javierarce apart from looking at the code, tested on staging too? You guys know these parts better than I do and I'd like to make sure we're not breaking anything when releasing this. Do we have some smoke tests for Pecan? |
No, sorry, I'll have a look to staging now. I don't think we have smoke tests for Pecan. I'll add a ticket to add some tests. |
Ok, I've tested it in staging using datasets from the Common Library and it seems to behave OK. |
Use pecan module instead of prior code from cartodb.js
Fixes #4999
Since extracting pecan-specific code to an external module, use this new module as dependency instead (of cartodb.js where the code were located previously).
Some details:
_analyzeStats
method (and related code) was also extracted to pecan module, to keep "magic numbers" in one place (see Replace internal magic numbers w/ optional variables for guessMap pecan#1 for motivation/planned work related to this)v1.x
to automatically get minor and patch updates onnpm install
(e.g. deploys), since they should be backward compatible. This will allow us to update pecan code w/o have to jump through all the hoops of creating code changes in this repo every time.Verified working locally, deployed on staging ded03 if you want to have a look yourself, should work just like before.
Old code will be removed from cartodb.js after this is merged and deployed.
ping @javisantana @javierarce @fdansv
cc @ohasselblad