Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focused JS tests fail due to implicit npm dependency #5171

Merged
merged 3 commits into from
Aug 24, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Aug 21, 2015

Fixes #5147

Bumping up to latest versions for outdated packages makes things works 🎉 (this was needed sooner or later anyways)
…except for gulp-* modules, because at least one native binding (gulp-ttf2woff2 doesn't seem to be used in currently specified versions) requires a newer version of node (v0.12). I don't want to force an upgrade to break builds or other dependencies that requires this older versions. We can investigate and bump those in isolation.

There's a little caveat of bumping the versions; I documented it inline with the code change edit: v3.4.2 of buffer module was released, so no temporary workaround needed anymore.

Also set all dependencies to use specific versions, to avoid dependency versions mismatches (per recommendation by @rochoa).

Verifying that things work (on my machine™):

  • Testing the typical builds (both local and production)
  • Running all tests locally (both headless and in browser)
  • Provoke a failing test un purpose (see screenshot below)
  • Browsing locally
  • Review build output

screen shot 2015-08-21 at 12 26 45
forced failed test, with proper stack trace

@xavijam since you suffered the focused-tests issues originally
@CartoDB/frontend FYI

Also needed to do a fix for source-map-support
@viddo
Copy link
Contributor Author

viddo commented Aug 24, 2015

Bump @xavijam can you verify that this fixes your trouble?

@xavijam
Copy link
Contributor

xavijam commented Aug 24, 2015

Yay! confirmed! 🇪🇸

viddo added a commit that referenced this pull request Aug 24, 2015
Fix focused JS tests fail due to implicit npm dependency
@viddo viddo merged commit ced86a4 into master Aug 24, 2015
@viddo viddo deleted the 5147-fix-focused-js-tests branch August 24, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants