Fix focused JS tests fail due to implicit npm dependency #5171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5147
Bumping up to latest versions for outdated packages makes things works 🎉 (this was needed sooner or later anyways)
…except for gulp-* modules, because at least one native binding (gulp-ttf2woff2 doesn't seem to be used in currently specified versions) requires a newer version of node (v0.12). I don't want to force an upgrade to break builds or other dependencies that requires this older versions. We can investigate and bump those in isolation.
There's a little caveat of bumping the versions; I documented it inline with the code changeedit: v3.4.2 of buffer module was released, so no temporary workaround needed anymore.Also set all dependencies to use specific versions, to avoid dependency versions mismatches (per recommendation by @rochoa).
Verifying that things work (on my machine™):
forced failed test, with proper stack trace
@xavijam since you suffered the focused-tests issues originally
@CartoDB/frontend FYI