Privacy toggler within create dataset dialog #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or not in the create dataset process
|
Deployed in staging ruis |
|
@javier could you take a quick look to this, specially to the texts? |
|
Code looks @javierarce what do you think? |
|
👍 code looks good to me. I'm going to review the texts before merging. |
| <button type="button" class="PrivacyToggler js-toggler PrivacyToggler--<%- privacy %> <%- isDisabled ? 'is-disabled' : '' %>" | ||
| data-title=" | ||
| <% if (!isDisabled) { %> | ||
| Your new dataset will be <%- privacy.toLowerCase() %>. Click to change it to <%- nextPrivacy.toLowerCase() %> |
There was a problem hiding this comment.
Let's add a new line here, so "Click" appears in the next line.
|
You're totally right, I'll make the change. |
javierarce
added a commit
that referenced
this pull request
Sep 7, 2015
Privacy toggler within create dataset dialog
|
👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it will let you to change the privacy of the import you want to start. But, if you don't have private_tables enabled under your user, it will redirect to your upgrade page when it is clicked.
For open source users that link will be disabled and it will show a "standard" text.
One important thing, by default, if user can create private datasets, the privacy value will be "PRIVATE", if the user can create private tables, of course, the value will be "PUBLIC".
Example:
We should review the texts of the tooltips cc @csobier @javierarce.
Possibility to change the privacy:
Upgrade:
Fixes #3111
REVIEWER: @alonsogarciapablo
cc @javierarce @saleiva