data library index page #5712
data library index page #5712
Conversation
matallo
commented
Sep 23, 2015
matallo
commented
- load cards (using Vis collection)
- implement more
- implement filters
- use Leaflet with hovers for the header country navigation
- add first tests
- implement preview
- implement search
- finish tests
| @@ -0,0 +1,10 @@ | |||
| @import "../old_common/mixins"; | |||
|
started the data library index page, inspired by the new explore, I came across the first questions
I wrote the filter links as they are in the dashboard, but had to add a new class for the styles, they live outside the list and item in the explore template, though we should unify this, worth crating an issue? |
| } | ||
| .DataLibrary-text { | ||
| color: #333; | ||
| font-weight: 200; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, font-weight, line-height
There was a problem hiding this comment.
from the shorthand I prefer:
- font-weight
- font-size
- line-height
@CartoDB/frontend
|
summoning @CartoDB/frontend here, per @xavijam request as I don't want to get off track from the decisions originally discussed with @javisantana, also I applied some of the implementations that have already been done for the explore, thinking of the filtering, ordering and load more (to be implemented). the https://github.com/CartoDB/cartodb/pull/5712/files#diff-07eeed666445b4ccdc97b529e78e6998R239 thinking about it, and despite this was decided with @javisantana, maybe it's not the best solution (I'm pretty sure it isn't) as this leaves us in a position where data-library is enabled for all users or none, instead of progressively open the feature to users. Thus, we could have a new route as it's been done with explore (correct me if I'm wrong @javierarce) and make proper use of feature flag. |
| @@ -93,4 +117,4 @@ | |||
| .u-showOnTablet { | |||
| display: inline-block !important; | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Files should end with a trailing newline
| @@ -220,6 +229,12 @@ a.Filters-cleanSearch { line-height:32px } | |||
| text-decoration: none; | |||
| } | |||
| } | |||
| .Filters-typeLink.Filters-typeLink--grey { | |||
| color: #979ea1; | |||
There was a problem hiding this comment.
Color #979ea1 should be written as #979EA1
… into 4795-data_library_markup
… into 4795-data_library_markup
… into 4795-data_library_markup
| } | ||
| .IconFont--center { | ||
| margin-left: -3px; | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
… into 4795-data_library_markup
… into 4795-data_library_markup
… into 4795-data_library_markup
… into 4795-data_library_markup
matallo
changed the title
|
retest this, please |
