Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon gamma suggestions for simple, choropleth, category, and density default settings #6775

Closed
wants to merge 1 commit into from

Conversation

makella
Copy link
Contributor

@makella makella commented Mar 3, 2016

@andrewxhill please review

The changes proposed in this pull request are:

  • to add polygon-gamma: 0.2 to simple, choropleth, category, and density polygons
  • for each type of polygon map, the line-width has been set to 0
  • in addition, I've adjusted the default size of the hexbins from 15 to 5

Explanation and Examples:

By default, polygon-gamma (polygon-antialiasing) is set to 1. If someone is designing a map and removes the outline, there is a noticeable gap in between each polygon. This is especially true with choropleth and category maps that vary in color over a variety of shapes and sizes. Here are two examples of this effect:

screen shot 2016-03-03 at 3 08 57 pm

screen shot 2016-03-03 at 3 09 06 pm

One solution is to modify the line-color of each polygon fill to get a smooth appearance but this can be tedious especially when there are a large number of classes/categories.

A default solution is to adjust the polygon-gamma setting to 0.2. In doing so, the antialiasing is minimized and each polygon appears to have an outline that is a shade of its fill color and makes for an overall smoother looking map:
screen shot 2016-03-03 at 3 12 54 pm
screen shot 2016-03-03 at 3 12 38 pm
screen shot 2016-03-03 at 3 14 37 pm
screen shot 2016-03-03 at 3 14 48 pm

Density Now:
screen shot 2016-03-03 at 3 19 48 pm

Proposed (with polygon-gamma and default size of 5):
screen shot 2016-03-03 at 3 20 42 pm

@andrewxhill
Copy link
Contributor

lgtm!
we'll need someone to test this.
also, i'm not sure the behavior of 'type' and what will happen with the new type, 'gamma'
let's see!

@saleiva can someone spare a few minutes to try this out? i know it isn't the future :) buuuut

@Cartofante
Copy link
Collaborator

Can one of the admins verify this patch?

@makella
Copy link
Contributor Author

makella commented Apr 26, 2016

After further review, for the new editor, let's not use plygon-gamma instead, we'll have a modified proposal for each map type's cartocss.

cc: @andrewxhill

@xavijam
Copy link
Contributor

xavijam commented Jun 27, 2016

Do you feel we could close this PR due to new builder changes?

@makella
Copy link
Contributor Author

makella commented Jun 27, 2016

yes, that sounds OK. @xavijam the only thing i would want to be sure of is that we get default styling for polygons (simple, choropleth, etc.) with some specific specs that i have to produce the best looking map while taking the polygon-gamma into account.

@xavijam
Copy link
Contributor

xavijam commented Jun 27, 2016

There is no default styling for polygons or lines, they take the same simple style as points, for the moment.

@makella
Copy link
Contributor Author

makella commented Jun 27, 2016

totally

i'm working on all that this week!

reference:
CartoDB/camshaft#86
#8163

@xavijam
Copy link
Contributor

xavijam commented Oct 1, 2016

Closing this one then 💋

@xavijam xavijam closed this Oct 1, 2016
@xavijam
Copy link
Contributor

xavijam commented Oct 1, 2016

Not deleting the branch by the way, just in case.

@elenatorro elenatorro deleted the polygon_gamma_update branch February 16, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants