Change debug notice to identify non-downloadable gdrive files #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People can share files in GDrive and select in the advanced sharing options that the users with which these files are shared are not authorized to download the files. This was causing CartoDB to crash, as it was expecting a DownloadUrl or an ExportLink, and in this "non-downloadable" scenario none of the options is available for the item. In this case, we just ignore the non-downloadable files and list the rest of the files. In case we need to debug this in the future, the non-downloadable debug message can be found at the notifier.
|
cc @jgoizueta ;) |
|
👍 |
iriberri
pushed a commit
that referenced
this pull request
Mar 15, 2016
Change debug notice to identify non-downloadable gdrive files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PRs: #6855
(Return nil for invalid files + report a debug message when it occurred)
People can share files in GDrive and select in the advanced sharing
options that the users with which these files are shared are not
authorized to download the files. This was causing CartoDB to crash, as
it was expecting a DownloadUrl or an ExportLink, and in this
"non-downloadable" scenario none of the options is available for the
item.
In this case, we just ignore the non-downloadable files and list the
rest of the files. In case we need to debug this in the future, the
non-downloadable debug message can be found at the notifier.
Closes #6854