Adding analysis quota #8872
Merged
Adding analysis quota #8872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this implements the quota element for analysis confirm, but it opens the 🍉 about how to know if the analysis is using one provider or other, or if it uses a paid service or not. Already discussed with @rafatower but I feel we need to discuss it at length. |
|
Let's merge it although it is not decided yet how to manage this problem. |
| .Infobox { | ||
| @include flex(10); |
There was a problem hiding this comment.
No idea why I wrote 10, with 2 would be enough.
| @@ -403,15 +403,15 @@ | |||
| "body": "<span class='CDB-Text is-semibold'>Your map is private</span>. Change your <a href='#'' class='js-change-privacy'>privacy settings</a> to embed your map. Right now it's private." | |||
| } | |||
| }, | |||
| "cartodbjs": { | |||
| "title": "CartoDB.js", | |||
| "CARTOjs": { | |||
|
@ethervoid another bit to take into account for quota requirements... this is turning a lot of fun |
|
Added some specs and removed all content not related with this Pull request @nobuti 💋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the quota analysis block for each analysis that needs non-free services, as in buffer or trade-areas.
CR: @nobuti
Fixes #8766.