Merge pull request #227 from CartoDB/column-encodings-fix

encodes to utf-8 to avoid issues between py2/3
CartoDB · Oct 10, 2017 · a694cfa · a694cfa
2 parents 3ccbd40 + 82a1d31
commit a694cfa
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/cartoframes/context.py b/cartoframes/context.py
@@ -380,7 +380,8 @@ def remove_tempfile(filepath):
         self._debug_print(tempfile=tempfile)
         df.drop(geom_col, axis=1, errors='ignore').to_csv(path_or_buf=tempfile,
                                                           na_rep='',
-                                                          header=pgcolnames)
+                                                          header=pgcolnames,
+                                                          encoding='utf-8')
 
         with open(tempfile, 'rb') as f:
             res = self._auth_send('api/v1/imports', 'POST',

diff --git a/test/test_context.py b/test/test_context.py
@@ -1,3 +1,5 @@
+# -*- coding: utf-8 -*-
+
 """Unit tests for cartoframes.layers"""
 import unittest
 import os
@@ -260,6 +262,18 @@ def test_cartocontext_write(self):
         # util columns + new column of type number
         self.assertDictEqual(cols['fields'], expected_schema)
 
+        # test properly encoding
+        df = pd.DataFrame({'vals':[1,2],'strings':['a','ô']})
+        cc.write(df, self.test_write_table, overwrite=True)
+
+        # check if table exists
+        resp = self.sql_client.send('''
+            SELECT *
+            FROM {table}
+            LIMIT 0
+            '''.format(table=self.test_write_table))
+        self.assertIsNotNone(resp)
+
     @unittest.skipIf(WILL_SKIP, 'no carto credentials, skipping')
     def test_cartocontext_mixed_case(self):
         cc = cartoframes.CartoContext(base_url=self.baseurl,