Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies file so that all examples run on binder #302

Merged

Conversation

hydrosquall
Copy link

@hydrosquall hydrosquall commented Dec 4, 2017

Changelog

  • Motivation: 2 of the example binders wouldn't work as-is because the Docker image that was built for them was missing a few python dependencies
  • Fix: I added a binder/requirements.txt to separate binder example dependencies from the requirements.txt associated with installation of the cartoframes module. I tested

Link to test: https://mybinder.org/v2/gh/hydrosquall/cartoframes/feature/add-binder-dependencies?filepath=examples

Hopefully this fix makes it easier for more people to try cartoframes without having to install anything locally. Separately, it looks like the failing Travis build is unrelated to this change, so I'm happy to rebase this branch at any point.

cc @andy-esch or any other project maintainers

@andy-esch
Copy link
Contributor

Hey @hydrosquall, thanks for this, this definitely is an improvement :) I see other repos have a binder/ directory with the requirements.txt and postBuild files, but I don't see it mentioned in binder's docs. Is it an undocumented feature?

BTW, For external PRs we first merge them into develop, then do a PR against master from there. I'll ping you on that PR.

@hydrosquall hydrosquall changed the base branch from master to develop December 4, 2017 21:07
@hydrosquall
Copy link
Author

hydrosquall commented Dec 4, 2017

@andy-esch : it's a feature that changed as of jupyterhub/binderhub#157 , but you're right that it seems to be undocumented. Would you be interested in filing a documentation bug on the binderhub repo? If not, I can do that next time I pass through.

It's something that popped up when I filed jvns/pandas-cookbook#62, because I didn't want the binder specific requirements.txt / Dockerfile to conflict with the pre-existing files with those same names.

Lastly, no worries! I've changed the base branch to develop

@andy-esch
Copy link
Contributor

No worries, all good as far as I'm concerned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants